Fix lack of confirmation when deleting an item with hidden children.
ClosedPublic

Authored by dfaure on May 1 2018, 3:03 PM.

Details

Summary

We need to go up to the source model to see if an item has children.

Test Plan

In a project, add a child to a task, and give it a start date in the future.
Without "Show future items" enabled, the child disappears as expected.
Now try deleting the parent task, it used to delete it without confirmation as if it
had no children, which was very dangerous (data loss of the invisible children).

Now at least it warns, so the user can wonder why this talks about children when none
are visible, and can enable the showing of future items to find out what they are
before possibly attempting another deletion.

Diff Detail

Repository
R4 Zanshin
Branch
warn_hidden_children (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure requested review of this revision.May 1 2018, 3:03 PM
dfaure created this revision.
ervin accepted this revision.Jul 17 2018, 3:45 PM
This revision is now accepted and ready to land.Jul 17 2018, 3:45 PM
dfaure closed this revision.Jul 18 2018, 7:58 AM