RunningTaskModel: update shown title when renaming the currently running task
ClosedPublic
Actions

Authored by dfaure on May 1 2018, 2:24 PM.

Details

Reviewers

ervin

Commits

Summary

This was missing, so the old title was always shown in the running-task-widget.

Test Plan

Start a task, rename it zanshin (either in the listview or in the editorview),
the running-task-widget now shows the new title.

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.May 1 2018, 2:24 PM

dfaure created this revision.

ervin set the repository for this revision to R4 Zanshin.Jul 17 2018, 3:41 PM

ervin requested changes to this revision.Jul 17 2018, 3:43 PM

ervin added inline comments.

src/presentation/runningtaskmodel.cpp
85	Space before & not after.

This revision now requires changes to proceed.Jul 17 2018, 3:43 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Jul 18 2018, 7:57 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/presentation/runningtaskmodel.h (2 lines)
M			src/presentation/runningtaskmodel.cpp (10 lines)
M			tests/units/presentation/runningtaskmodeltest.cpp (45 lines)
M			tests/units/widgets/runningtaskwidgettest.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33396	1790e91		May 1 2018, 2:24 PM	★	★
Diff 2	37993	acc4714	R4:9674d8c5c63ac346f18bb6891b8094a91875b19a	Jul 18 2018, 7:57 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a941ac388bbe	0d1ea5d96967	1790e91007a6	David Faure	RunningTaskModel: update shown title when renaming the currently running task (Show More…)	May 1 2018, 2:22 PM