Differential D12624

Resolve KGpg crashing when setting trust level to ultimate.
ClosedPublic
Actions

Authored by kavindap on Apr 30 2018, 10:10 PM.

Details

Reviewers
dakon
Commits
R358:68fc9165947c: Resolve KGpg crashing when setting trust level to ultimate
Summary

KGpg with GnuPG 2.2 crashes when setting trust level of a imported key to ultimate.

BUG: 373909, 391499

Test Plan
  1. Generate a key pair on another machine.
  2. Export private key with gpg --export-private-key [ID] > private.key
  3. Import this private key to KGpg.
  4. Edit key property, change owner trust to ultimate.
  5. Click "OK" or "Apply".

Diff Detail

Repository
R358 KGpg
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kavindap created this revision.Apr 30 2018, 10:10 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptApr 30 2018, 10:10 PM
kavindap requested review of this revision.Apr 30 2018, 10:10 PM
kavindap retitled this revision from Summary: Resolve KGpg crashing when setting trust level to ultimate. BUG: 373909 to Resolve KGpg crashing when setting trust level to ultimate. .Apr 30 2018, 10:16 PM
kavindap edited the summary of this revision. (Show Details)
kavindap edited the test plan for this revision. (Show Details)
kavindap added a reviewer: dakon.
ltoscano retitled this revision from Resolve KGpg crashing when setting trust level to ultimate. to Summary: Resolve KGpg crashing when setting trust level to ultimate..Apr 30 2018, 10:16 PM
ltoscano edited the summary of this revision. (Show Details)
ltoscano edited the test plan for this revision. (Show Details)
ltoscano retitled this revision from Summary: Resolve KGpg crashing when setting trust level to ultimate. to Resolve KGpg crashing when setting trust level to ultimate..Apr 30 2018, 10:37 PM
ltoscano edited the summary of this revision. (Show Details)
ltoscano edited the test plan for this revision. (Show Details)
dakon requested changes to this revision.May 6 2018, 6:35 PM

Please use KGpgTransaction::keyConsidered() here and remove the current callsites of that function.

This revision now requires changes to proceed.May 6 2018, 6:35 PM
kavindap updated this revision to Diff 33740.May 7 2018, 3:52 AM
  • using KGpgTransaction::keyConsidered()
kavindap added a dependent revision: Restricted Differential Revision.May 7 2018, 3:25 PM
kavindap removed a dependent revision: Restricted Differential Revision.
kavindap updated this revision to Diff 33764.May 7 2018, 3:37 PM
kavindap updated this revision to Diff 33766.
kavindap edited the summary of this revision. (Show Details)
kavindap updated this revision to Diff 33773.May 7 2018, 4:07 PM
dakon requested changes to this revision.May 7 2018, 5:08 PM
dakon added inline comments.
transactions/kgpgdelkey.cpp
55

One space too much before the if

This revision now requires changes to proceed.May 7 2018, 5:08 PM
kavindap updated this revision to Diff 33785.May 7 2018, 6:20 PM
dakon accepted this revision.May 7 2018, 6:22 PM
This revision is now accepted and ready to land.May 7 2018, 6:22 PM
Closed by commit R358:68fc9165947c: Resolve KGpg crashing when setting trust level to ultimate (authored by Harindu Dilshan <harindudilshan@gmail.com>, committed by dakon). · Explain WhyMay 7 2018, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33790

View Options

transactions/kgpgchangedisable.h

Loading...
View Options

transactions/kgpgchangedisable.cpp

Loading...
View Options

transactions/kgpgdelkey.cpp

Loading...
View Options

transactions/kgpgsignkey.cpp

Loading...
View Options

transactions/kgpgtransactionprivate.cpp

Loading...