Checkbox style enhancement and background bug correction for dark theme
https://github.com/KDE/plasma-nm/pull/2
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
This comment was removed by intika.
Comment Actions
this change provide :
- Different checkbox style
- Correct bug : background of the checkbox should be transparent when not checked this result in a white checkbox for dark theme making the user a little bit confused
i used plasmawindowed to make the capture and run different version at the same time
yes indeed it's a little bit off do i need to re-post ?
Comment Actions
imo that's not a thing to be fixed at the applet level, that's how that particular plasma theme looks, you can't fix a 3rd party plasma theme by patching applets to not follow it.
Probably we new a new standard element for checkbox background, but that has to be fixed in base theme and components
Comment Actions
@mart yes indeed i had the same thoughts afterward, this code need to be fixed upfront in QtQuick.Controls.Styles.Plasma or org.kde.plasma.components or somewhere else... any way there is track here if someone will work on it or need that modification :)