Shouldn't this check if(m_process->state() != QProcess::NotRunning) be done in a central place so that this logic applies for all backends? It shoudln't be possible to call the interrupt action in worksheet or in cantor_shell/part at all if the process is not running. But we can maybe also safe-guard this in all the *session.cpp files.

calling quit() in an octave session results in a permanent "Calculating..." message in the status bar. Clicking on the interrupt crashes cantor. This problem is a bit similar to https://bugs.kde.org/show_bug.cgi?id=372075.

In D12567#255054, @asemke wrote:

Shouldn't this check if(m_process->state() != QProcess::NotRunning) be done in a central place so that this logic applies for all backends? It shoudln't be possible to call the interrupt action in worksheet or in cantor_shell/part at all if the process is not running. But we can maybe also safe-guard this in all the *session.cpp files.

I have checked all session files, and all the files, except octavesession.cpp, or have has existence checking before kill the process or even haven't killed the process.

calling quit() in an octave session results in a permanent "Calculating..." message in the status bar. Clicking on the interrupt crashes cantor. This problem is a bit similar to https://bugs.kde.org/show_bug.cgi?id=372075.

It look similar, but I don't think, that they have same reason. Python2 doesn't use process, it uses python binding for c++. And I think, the problem, that we run python command without checking python status, so then the problem arise, when we run print(quit()) after quit().

In D12567#254958, @sirgienko wrote:

@asemke, which version I should set in FIXED-IN?
I think 18.04.1, am I right?

yes, we'll cherry-pick the fixes to the branch for the patch release.

In D12567#255094, @sirgienko wrote:

In D12567#255054, @asemke wrote:

Shouldn't this check if(m_process->state() != QProcess::NotRunning) be done in a central place so that this logic applies for all backends? It shoudln't be possible to call the interrupt action in worksheet or in cantor_shell/part at all if the process is not running. But we can maybe also safe-guard this in all the *session.cpp files.

I have checked all session files, and all the files, except octavesession.cpp, or have has existence checking before kill the process or even haven't killed the process.

I don't see such a check in maximasessin.cpp. But ok, let's safe-guard everywhere.