Details
Details
- Reviewers
hindenburg - Group Reviewers
Konsole - Commits
- R319:ca36b8861952: Do not paint long pre-edit text outside display
- Turn on IME (tested with ibus+anthy)
- Type (without accepting) long text using IME
Expected result: text should not be drawn outside terminal
Actual result: text is drawn on terminal, margins, scrollbar
Diff Detail
Diff Detail
- Repository
- R319 Konsole
- Branch
- arc/cursor-fixes/0005-Do-not-paint-long-pre-edit-text-outside-display
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
What language are you using? I can't reproduce testing a few rtl and ltr - also did the recent commit change this?
Comment Actions
The language in example is Japanese. This is unrelated to last RTL-related commit.
You can't test it with anything that runs on TTY. IME pre-edit text does not interact with TTY - Konsole receives (through Qt) either "render this string in a nice way" or "use this string as regular input" message. The commit fixes the former.
Comment Actions
OK looks fine - I wonder if using intersected() is any better/faster/more readable/etc
Comment Actions
Every reasonable code which solves this problem gives the same assembly (with -O2, used in release builds), so speed will not change.
As for "more readable" you're right. Additionally I've decided to separate the original rect. Any code added in the same line as the last QRect parameter might "disappear" during quick code scan.