Differential D12535

[timer applet] disable animation on timer pause
Needs RevisionPublic
Actions

Authored by mmazur on Apr 26 2018, 8:35 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

The animation is surprisingly cpu heavy at times and really distracting.

BUG: 391634

Diff Detail

Repository
R114 Plasma Addons
Branch
timer3 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
mmazur created this revision.Apr 26 2018, 8:35 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 26 2018, 8:35 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mmazur requested review of this revision.Apr 26 2018, 8:35 AM
davidedmundson requested changes to this revision.Apr 26 2018, 9:21 AM
davidedmundson added a subscriber: davidedmundson.

Which is the main rationale? The fact that it's annoying or the CPU load?

Porting to OpacityAnimator instead of NumberAnimation will give a *significant* CPU reduction; there's also an important patch in Qt5.something that didn't clear the expired animations that quickly added up.

This revision now requires changes to proceed.Apr 26 2018, 9:21 AM
mmazur added a comment.Apr 26 2018, 10:03 AM

Initially a few years ago when I went kde5 I made this patch because of the cpu usage, which was stupid high (and it seems I'm not the only one that noticed). Some time later it occurred to me that it has the added benefit of my desktop not blinking at me when I want the timer to stop counting for an extended period of time.

Possibly the optimal solution here would be to rewrite the animation to use something less cpu heavy and add "don't blink on pause" as a config option. But such a patch would not be authored by me, especially the rewriting animation part.

Revision Contents
Changeset List

Diff 33131

View Options

applets/timer/package/contents/ui/TimerView.qml

Loading...
View Options

applets/timer/package/contents/ui/main.qml

Loading...