Differential D12518

[Button Styles] Fill height and vertical align
ClosedPublic
Actions

Authored by broulik on Apr 25 2018, 2:11 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R242:c9e8e2e717f2: [Button Styles] Fill height and vertical align
Summary

Otherwise the Text will never grow below its preferred height as the button grows smaller and will eventually leak outside at the bottom rather than stay centered.

BUG: 393388

Test Plan

Regression caused by D11557

  • Global menu buttons are vertically aligned correctly in a narrow panel again
  • Other buttons looked fine

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 25 2018, 2:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 25 2018, 2:11 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Apr 25 2018, 2:11 PM
broulik updated this revision to Diff 33073.Apr 25 2018, 2:15 PM
  • Also unsed Label default height to avoid binding loops
This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2018, 3:20 PM
Closed by commit R242:c9e8e2e717f2: [Button Styles] Fill height and vertical align (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33151

View Options

src/declarativeimports/plasmastyle/ButtonStyle.qml

Loading...
View Options

src/declarativeimports/plasmastyle/ToolButtonStyle.qml

Loading...