Differential D12495

[Desktop Theme KCM] Workaround bug in FileDialog
ClosedPublic
Actions

Authored by broulik on Apr 24 2018, 2:18 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:c5c756623a34: [Desktop Theme KCM] Workaround bug in FileDialog
Summary

When FileDialog is created with visible set to true it will open the dialog immediately before its properties are set leading to a dialog with no title and filter.

Test Plan

5.12 branch

Opened dialog, verified title said "Open Theme" and file name filter was set
QtDialogs is pretty much unmaintained and to be replaced by some platform import(?) so a qt bug report probably won't help

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 24 2018, 2:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2018, 2:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 24 2018, 2:18 PM
davidedmundson accepted this revision.Apr 24 2018, 2:29 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
kcms/desktoptheme/package/contents/ui/main.qml
227–228

would a

Component.onCompleted: open() in here work? it would be more self-contained

This revision is now accepted and ready to land.Apr 24 2018, 2:29 PM
Closed by commit R119:c5c756623a34: [Desktop Theme KCM] Workaround bug in FileDialog (authored by broulik). · Explain WhyApr 24 2018, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32976

View Options

kcms/desktoptheme/package/contents/ui/main.qml

Loading...