Differential D12434

KSMTP: Fix sending emails where a line starts with a dot
ClosedPublic
Actions

Authored by dfaure on Apr 22 2018, 9:56 AM.

Details

Reviewers
dvratil
mlaurent
Commits
R733:988e06498609: KSMTP: Fix sending emails where a line starts with a dot
Summary

My previous fix was incomplete because it only considered lines
with a single dot, and not the case where two such lines followed each
other.

Test Plan

Updated unittest.

Diff Detail

Repository
R733 KSmtp
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Apr 22 2018, 9:56 AM
dfaure updated this revision to Diff 32775.
dfaure created this revision.

Add bug number

mlaurent added inline comments.Apr 22 2018, 9:59 AM
autotests/smtptest.cpp
219

duplicate entry

dfaure added inline comments.Apr 22 2018, 10:02 AM
autotests/smtptest.cpp
219

yes, on purpose, see the bug report :-)

mlaurent accepted this revision.Apr 22 2018, 10:04 AM

Ok thanks for explanation

This revision is now accepted and ready to land.Apr 22 2018, 10:04 AM
Closed by commit R733:988e06498609: KSMTP: Fix sending emails where a line starts with a dot (authored by dfaure). · Explain WhyApr 22 2018, 10:08 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2018, 10:08 AM

Revision Contents
Changeset List

PathPackages
Mautotests/smtptest.cpp (9 lines)
Msrc/sendjob.cpp (2 lines)

Diff 32778

View Options

autotests/smtptest.cpp

Loading...
View Options

src/sendjob.cpp

Loading...