Differential D1241

Fix crash in relativeActivity
ClosedPublic
Actions

Authored by davidedmundson on Mar 28 2016, 11:42 PM.

Details

Reviewers
ivan
Group Reviewers
Plasma
Commits
R119:45bf19ea89f4: Fix crash in relativeActivity
Summary

If we were on activity 0 and tried to load the previous activity we
would crash.

-1 % rowCount == -1 in C++

we then try and use that index which is obviously invalid.

BUG: 361056

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 2986.Mar 28 2016, 11:42 PM
davidedmundson retitled this revision from to Fix crash in relativeActivity.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 28 2016, 11:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan accepted this revision.Mar 29 2016, 11:14 AM
ivan added a reviewer: ivan.
This revision is now accepted and ready to land.Mar 29 2016, 11:14 AM
Closed by commit R119:45bf19ea89f4: Fix crash in relativeActivity (authored by davidedmundson). · Explain WhyMar 29 2016, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2997

View Options

imports/activitymanager/sortedactivitiesmodel.cpp

Loading...