Differential D12387

LdapUrl: fix LDAP queries broken with non-ascii search strings.
ClosedPublic
Actions

Authored by dfaure on Apr 20 2018, 5:32 PM.

Details

Reviewers
dvratil
mlaurent
Commits
R178:aef21d5c5f91: LdapUrl: fix LDAP queries broken with non-ascii search strings.
Summary

Qt5 made query() return a PrettyDecoded query string, while the code
was calling fromPercentEncoding for the filter, i.e. assuming it to be FullyEncoded.

With unittest

Test Plan

Typing Valérie in kmail composer now finds LDAP completion correctly.

Diff Detail

Repository
R178 PIM: KLDAP
Branch
non-ascii-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Apr 20 2018, 5:32 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 20 2018, 5:32 PM
dfaure requested review of this revision.Apr 20 2018, 5:32 PM
dvratil accepted this revision.Apr 20 2018, 5:44 PM
This revision is now accepted and ready to land.Apr 20 2018, 5:44 PM
dfaure closed this revision.Apr 20 2018, 5:58 PM

Revision Contents
Changeset List

PathPackages
Mautotests/testkldap.cpp (30 lines)
Msrc/ldapurl.cpp (2 lines)

Diff 32660

View Options

autotests/testkldap.cpp

Loading...
View Options

src/ldapurl.cpp

Loading...