Differential D12332

Send Runcommand setup package from phone
ClosedPublic
Actions

Authored by nicolasfella on Apr 18 2018, 9:49 PM.

Details

Reviewers

albertvaka

Group Reviewers

KDE Connect

Commits

R225:4deeb5e0611c: Send Runcommand setup package from phone

Summary

Also remove some leftover code from the prevoius attempt

Test Plan

Open command list, click Floating Action Button, look for KCM window on desktop.

Diff Detail

Repository

R225 KDE Connect - Android application

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Apr 18 2018, 9:49 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 18 2018, 9:49 PM

Remove import

Add explanation dialog

Ping? The current state is broken because the code from my first attempt is still in and the desktop now reports that commands can be added, so the dialog will be shown but do nothing

Restricted Application added a subscriber: kdeconnect. · View Herald TranscriptMay 10 2018, 4:34 PM

LGTM

src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandActivity.java
127	Change "Ok" for a string resource.

This revision is now accepted and ready to land.May 10 2018, 5:17 PM

Closed by commit R225:4deeb5e0611c: Send Runcommand setup package from phone (authored by nicolasfella). · Explain WhyMay 10 2018, 5:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		res/layout/activity_runcommand.xml (2 lines)
D	M	res/layout/addcommanddialog.xml (34 lines)
M		res/values/strings.xml (4 lines)
D	M	src/org/kde/kdeconnect/Plugins/RunCommandPlugin/AddCommandDialog.java (53 lines)
M		src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandActivity.java (36 lines)
M		src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandPlugin.java (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32519	bc33001		Apr 18 2018, 9:49 PM	★	★
Diff 2	32520	bc33001	- Remove import	Apr 18 2018, 9:50 PM	★	★
Diff 3	32521	bc33001	- Add explanation dialog	Apr 18 2018, 9:58 PM	★	★
Diff 4	33959	ff2354a	R225:4deeb5e0611c992f2005dcdacb60651ee6da7cfb	May 10 2018, 5:47 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b36df6320246	31f62db98a89	9121a22f3879	Nicolas Fella	Add explanation dialog	Apr 18 2018, 9:58 PM
9121a22f3879	aa00944b615a	f472fdb6f5fd	Nicolas Fella	Remove import	Apr 18 2018, 9:49 PM
f472fdb6f5fd	9af57a6ede2a	bc330018e14e	Nicolas Fella	Send Runcommand setup package from phone (Show More…)	Apr 18 2018, 9:47 PM