Read theme.conf of themes
ClosedPublic
Actions

Authored by fvogt on Apr 18 2018, 6:18 PM.

Details

Reviewers

Group Reviewers

Commits

Summary

Otherwise kcm_sddm ignores values in there. Previously, a theme with a default
background image reverts to a color background on save.

Test Plan

Ran kcm_sddm and saved without changes. The background type is still image.

Repository

R123 SDDM Configuration Panel (KCM)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

fvogt requested review of this revision.Apr 18 2018, 6:18 PM

(Actually targeting the Plasma/5.12 branch)

1 minor change.

src/themeconfig.cpp
169–171	nice solution "NoGlobals" - Cascade to system settings, but omit user's globals. should work better. It will include the added sources, but no more

This revision is now accepted and ready to land.Apr 18 2018, 6:32 PM

src/themeconfig.cpp
169–171	https://cgit.kde.org/kconfig.git/tree/src/core/kconfig.h#n97 says that it's the same value, isn't it?

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/themeconfig.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32499	825443e		Apr 18 2018, 6:18 PM	★	★
Diff 2	32549	b654b0f	R123:ebdfab7e08671b5165f52118cabdf4d1d6c14bb2	Apr 19 2018, 11:21 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
ef56c302b2d2	3f9858ba68b0	825443ef7d33	Fabian Vogt	Read theme.conf of themes (Show More…)	Apr 18 2018, 6:18 PM