Use some lambdas to simplify the code
Details
Details
- Reviewers
- None
- Group Reviewers
KDE Connect - Commits
- R225:a4e2af2c51a6: Simplify failed plugin list creation
Denie some permissions, open permission explanation dialogs
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Branch
- java8
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/org/kde/kdeconnect/UserInterface/DeviceFragment.java | ||
|---|---|---|
| 330 ↗ | (On Diff #32876) | You removed the retry code. Does that make sense? (ie never fired, or retries happen anyway?) |
| src/org/kde/kdeconnect/UserInterface/PluginSmallEntryItem.java | ||
| 25 ↗ | (On Diff #32223) | What does this name mean? I'd pick something clearer, although that seems hard in this case. |
| src/org/kde/kdeconnect/UserInterface/DeviceFragment.java | ||
|---|---|---|
| 330 ↗ | (On Diff #32876) | It was blocking making it a lambda, but it was probably a bad idea to blindly remove it |
| src/org/kde/kdeconnect/UserInterface/PluginListItem.java | ||
|---|---|---|
| 26 ↗ | (On Diff #32875) | Better, but these are only for the required permissions, failure, etc., right? Maybe FailedPluginListItem? |