Clicking outside preview box moves view to that point
ClosedPublic

Authored by seorasm on Apr 13 2018, 5:38 PM.

Details

Summary

Clicking outside of the preview box in the overview docker now moves the view of the canvas to be centered at that point.

BUG: 384687

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
seorasm requested review of this revision.Apr 13 2018, 5:38 PM
seorasm created this revision.
emmetoneill added a subscriber: emmetoneill.EditedApr 14 2018, 10:30 PM

Seems to work nicely!

My only small critique is that it would be nice if jumping transitioned more smoothly into dragging.

Right now you can click within your current selection and drag the box around, or thanks to your patch you can click anywhere to jump around. But, if you click to jump to a new position and then (while still holding the mouse down) you drag in a direction, the preview box doesn't drag. In other words, you have to click once to jump to a new position, and then click again to drag from there. I realize that's kind of a nitpick though, haha.

Nevertheless, nice one. =]

seorasm updated this revision to Diff 32432.Apr 17 2018, 11:32 PM

Thanks, yeah I didn't think of that. I've changed the patch so you can drag straight after clicking outside the box.
This is only my 3rd patch, so I think I need someone else to commit it for me, if it looks ok. I'll apply for a dev account after this patch.

dkazakov accepted this revision.Apr 18 2018, 8:43 AM
dkazakov added a subscriber: dkazakov.

Hi, @seorasm!

The patch looks and works perfectly! I will push the patch to master now! :)

This revision is now accepted and ready to land.Apr 18 2018, 8:43 AM
This revision was automatically updated to reflect the committed changes.