Differential D12141

Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools
ClosedPublic
Actions

Authored by heikobecker on Apr 12 2018, 9:03 AM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:4a4e8216aa68: Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools
Summary

Otherwise cmakes complains when invoked with
-DCMAKE_DISABLE_FIND_PACKAGE_KF5Wayland=TRUE: "CMake Error at
/usr/share/cmake/Modules/FeatureSummary.cmake:459 (message):
feature_summary() Error: REQUIRED package(s) are missing, aborting
CMake run."

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Apr 12 2018, 9:03 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptApr 12 2018, 9:03 AM
heikobecker requested review of this revision.Apr 12 2018, 9:03 AM
apol added a subscriber: apol.Apr 12 2018, 10:04 AM
apol added inline comments.
CMakeLists.txt
18–21

You don't need to find KF5 again, it can be appended in the call above.

heikobecker updated this revision to Diff 31961.Apr 12 2018, 10:28 AM

Combined the two find_package(KF5...) calls as suggested.

heikobecker marked an inline comment as done.Apr 12 2018, 10:28 AM
apol accepted this revision.Apr 12 2018, 10:34 AM
This revision is now accepted and ready to land.Apr 12 2018, 10:34 AM
Closed by commit R224:4a4e8216aa68: Use OPTIONAL_COMPONENTS to search for KF5Wayland and DocTools (authored by heikobecker). · Explain WhyApr 12 2018, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (6 lines)
Mplugins/mousepad/CMakeLists.txt (2 lines)

Diff 31962

View Options

CMakeLists.txt

Loading...
View Options

plugins/mousepad/CMakeLists.txt

Loading...