| sebas |
| Plasma |
This is a workaround for https://bugreports.qt.io/browse/QTBUG-52118
It should take effect whenever the parent surface's state is applied,
but QtWayland never commits the parent surface. Thus the position is
always wrong.
Having a workaround for that in our server code is not good, but better
than completely broken applications such as Systemsettings.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/server/subcompositor_interface.cpp | ||
|---|---|---|
| 211 ↗ | (On Diff #2934) | I'm not sure I understand ... this line applies to the "not sync" case, so we'll want to schedule an update, but then there's that return. Should it not be the other way round, that is "apply directly when sync, schedule when desync"? |
| src/server/subcompositor_interface.cpp | ||
|---|---|---|
| 211 ↗ | (On Diff #2934) | I'm trying here to workaround Qt's bug in the least dangerous way. Qt has all surfaces in desync, that's why I check whether it's desync. For desync a direct update is not as bad as for a synced surface. But yeah the code is wrong and not following the spec. But we cannot go on Wayland with systemsettings that broken :-( |