Added feature to remember the zoom set on a host
AbandonedPublic

Authored by cullmann on Apr 10 2018, 6:55 PM.

Details

Reviewers
drosca
anmolgautam
Group Reviewers
Falkon

Diff Detail

Repository
R875 Falkon
Branch
zoom-pref
Lint
No Linters Available
Unit
No Unit Test Coverage
anmolgautam created this revision.Apr 10 2018, 6:55 PM
Restricted Application added a project: Falkon. · View Herald TranscriptApr 10 2018, 6:55 PM
Restricted Application added a subscriber: falkon. · View Herald Transcript
anmolgautam requested review of this revision.Apr 10 2018, 6:55 PM
anmolgautam retitled this revision from Summary: Added feature to remember the zoom set on a host to Added feature to remember the zoom set on a host.Apr 11 2018, 5:05 AM
anmolgautam added a reviewer: Falkon.
drosca requested changes to this revision.Apr 13 2018, 8:03 AM

I don't see why this is called DefaultZoomManager when it doesn't change default zoom, but it changes current zoom for pages.

As I said on IRC, I'd like to have some generic "per-site settings", so I don't like it in current state. It should be made to be able to handle multiple "settings" in addition to zoom value (eg. allow cookies, various permissions like load images and html5 permissions).
There is already similar functionality with HTML5 permissions (lib/tools/html5permissions), so it should be integrated into one "manager" class (something like SiteSettingsManager).

Another issue is where to store the preferences. Currently it is using QSettings (both this patch and html5permissions), but it's not good for this usecase as it always completely re-writes the .ini file on any change, thus saving a lot of data there will make all manipulation with the file slow.
I think best way is to add new table (eg. sitesettings) in sqlite database (with async api SqlQueryJob to not block main thread):

domainzoom_levelallow_cookiesallow_location
kde.org8TRUEFALSE

And last thing, do we really want to show in gui all domains where zoom was changed and add option to edit it there? It may be a very long list, and probably not even useful as it can be changed by visiting that domain directly. Of course, the situation is different with html5permissions, but even there it could be solved by adding a permissions settings in "site info" popup (after clicking on site icon in locationbar).

This revision now requires changes to proceed.Apr 13 2018, 8:03 AM
cullmann commandeered this revision.Feb 12 2019, 7:44 PM
cullmann added a reviewer: anmolgautam.
cullmann added a subscriber: cullmann.

Hi, as this is dead >> 6 months, I will now abandon it.
If you want to start working again on it, please reopen it, thanks!

cullmann abandoned this revision.Feb 12 2019, 7:44 PM