Differential D12060

Remove unnecessary update()
ClosedPublic
Actions

Authored by huoni on Apr 9 2018, 3:45 AM.

Details

Reviewers
rkflx
Group Reviewers
Gwenview
Commits
R260:b5f3c592931d: Remove unnecessary update()
Summary

This update(), added in D11796, is no longer necessary since D11795
switched to using QGraphicsOpacityEffect instead of setOpacity.

Test Plan

Open a raster and SVG image in View compare mode.
Zoom both images in and out, and ensure no artifacts like parts of the
selection rect are left over.

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
huoni requested review of this revision.Apr 9 2018, 3:45 AM
huoni created this revision.
muhlenpfordt added a subscriber: muhlenpfordt.Apr 9 2018, 8:10 AM

Seems to be really unnecessary. ;)
I can't spot anything unusual, no matter what Animations option is set.

rkflx accepted this revision.Apr 9 2018, 11:41 PM

LGTM. I guess this got somehow lost in the discussion in D11942.

This revision is now accepted and ready to land.Apr 9 2018, 11:41 PM
Closed by commit R260:b5f3c592931d: Remove unnecessary update() (authored by huoni). · Explain WhyApr 10 2018, 12:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31784

View Options

lib/documentview/svgviewadapter.cpp

Loading...