Always preserve line breaks on "Select All" action
ClosedPublic

Authored by mglb on Apr 9 2018, 2:48 AM.

Details

Summary

_preserveLineBreaks was set/reset only in mousePressEvent, and was
initially disabled. This led to use of the last setting from mouse
selection, or initial value, by "Select All".

BUG: 352616

Test Plan
  • Start Konsole
  • Run seq 100
  • (optional, test should give the same effect with and without this step) Press Ctrl and select some text
  • Edit → Select All
  • Copy
  • Paste in any text editor

Expected result: text should be in multiple lines (like on

Konsole screen)

Actual result: text is pasted as one line

Regression tests

  • Run seq 100
  • Select few lines using mouse
  • Copy
  • Paste in any text editor

Expected result: text should be in multiple lines (like on

Konsole screen)
  • Run seq 100
  • Press Ctrl and select few lines using mouse
  • Copy
  • Paste in any text editor

Expected result: text should be pasted as one line

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb requested review of this revision.Apr 9 2018, 2:48 AM
mglb created this revision.
hindenburg accepted this revision.Apr 10 2018, 1:10 AM
hindenburg edited the summary of this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg added a subscriber: hindenburg.

Thanks, nice catch

This revision is now accepted and ready to land.Apr 10 2018, 1:12 AM
mglb edited the test plan for this revision. (Show Details)Apr 10 2018, 7:21 AM

I guess the 'e' was removed by mistake

This revision was automatically updated to reflect the committed changes.

Yea, I try to get the lines to be 78 columns or less so they are readable in git. I wish phabricator had column indicators.