Now string highlighter regex highlighte two strings, standing neary, as one string, that incorrect. So it fix it.
Details
Details
- Open Octave, Scilab, Lua, Sage session, write '3', '4', '5'
- Make sure, that string highlighting wrong.
- Appy the patch
- Test again and check, that all okay
Diff Detail
Diff Detail
- Repository
- R55 Cantor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@asemke, Should I try to get KDE Devlepoer account to send directly to repository such minor changes, like this?
Or you accepting small patches like this don't problem for you?
Comment Actions
What exactly is wrong here?
I don't exactly understand the problem you're trying to fix. Octave session for me without your patch:
What exactly is wrong here?
Comment Actions
I don't exactly understand the problem you're trying to fix. Octave session for me without your patch:
What exactly is wrong here?
Commas not a part of string, but highlighter as string. It's wrong, isn't it?
Comment Actions
You showed already a lot of interest in Cantor and good understanding of the code and architecture. If you plan to further contribute here it makes sense to apply for a KDE account. But let's maybe still go via the review process at the beginning. Don't push directly without a review. Even small fixes can cause big troubles. Doing review for small patches is ok for me, don't worry about this.
Comment Actions
I don't exactly understand the problem you're trying to fix. Octave session for me without your patch:
What exactly is wrong here?Commas not a part of string, but highlighter as string. It's wrong, isn't it?
Sorry, I over looked the highlighted commas. Your patch is ok.