Differential D11965

Remove then branch of always false condition
ClosedPublic
Actions

Authored by sirgienko on Apr 5 2018, 3:28 PM.

Details

Reviewers
asemke
Group Reviewers
Cantor
Commits
R55:7d4bbbb9d3d1: Fixed missing latex typesetting.
R55:00fffbe1ce1d: Remove then branch of always false condition
Summary

The condition in OctaveExpresssion::parseError never comes true, so remove then branch.

Diff Detail

Repository
R55 Cantor
Lint
Lint Skipped
Unit
Unit Tests Skipped
sirgienko created this revision.Apr 5 2018, 3:28 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 5 2018, 3:28 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
sirgienko requested review of this revision.Apr 5 2018, 3:28 PM
asemke added a comment.Apr 5 2018, 7:14 PM

What about octave warnings? Are they written out to stderr by octave?

sirgienko added a comment.EditedApr 5 2018, 7:27 PM
In D11965#240723, @asemke wrote:

What about octave warnings? Are they written out to stderr by octave?

Yes, the warnings write to stderr.

asemke accepted this revision.Apr 7 2018, 6:53 AM
This revision is now accepted and ready to land.Apr 7 2018, 6:53 AM
Closed by commit R55:00fffbe1ce1d: Remove then branch of always false condition (authored by sirgienko, committed by asemke). · Explain WhyApr 7 2018, 6:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31404

View Options

src/backends/octave/octaveexpression.cpp

Loading...