[potd dataengine] De-pimplify potd providers for more simple code
ClosedPublic

Authored by kossebau on Apr 5 2018, 1:16 PM.

Details

Summary

There is no need to use pimpl for non-public-API classes.

While touching the code, also change to use consistently
modern signal-slot connections.

Test Plan

All plugins still build, load & work as before.

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 5 2018, 1:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 5 2018, 1:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Apr 5 2018, 1:16 PM

If noone objects, will push on Fri, April 13th.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 12 2018, 10:50 PM
This revision was automatically updated to reflect the committed changes.