Fix Bug 371010: Position Marker is gone/invisible

Authored by cstagner on Apr 1 2018, 1:02 AM.


Group Reviewers

The position marker plugin queries the direction of "north" by computing latitude + 0.1 radians. This point can be off the screen, however, and the rendering function will early-out.

Skip the off-the-screen check for this northing point.

Test Plan
  1. Resize the main Marble window to be no more than 768 pixels tall.
  2. Switch to the Mercator view
  3. Supply Marble with a valid position from any source
  4. Zoom in to no more than five ticks from maximally-zoomed in
  5. Ensure bug can be reproduced
  6. Apply patch
  7. Ensure position marker is visible under the above conditions

Diff Detail

R34 Marble
Lint Skipped
Unit Tests Skipped
cstagner created this revision.Apr 1 2018, 1:02 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 1 2018, 1:02 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
cstagner requested review of this revision.Apr 1 2018, 1:02 AM
rahn accepted this revision.Feb 26 2019, 11:00 AM
rahn added a subscriber: rahn.

sorry for noticing this late

This revision is now accepted and ready to land.Feb 26 2019, 11:00 AM
Restricted Application edited subscribers, added: kde-edu, marble-devel; removed: KDE Edu. · View Herald TranscriptFeb 26 2019, 11:00 AM