DocumentViewController already had a function that enabled/disabled
the View actions (e.g. Zoom to Fit) based on whether View
was visible among other things. However this was never called when
switching from View to Browse.
This patch therefore connects MainWindow::viewModeChanged to this
function.
This ensures shortcuts like F for Zoom to Fit are ignored
while in Browse so they are passed to the underlying item model.
| No Linters Available |
| No Unit Test Coverage |
Sorry to hear, but which Diff is this supposed to be a duplicate of? For me the problem is still there, and your patch fixes it (pending complete review).
Occurred to me that you may have wasted time reviewing this patch. Apologies for that!
Oh no, not at all ;) Your patches are next up for review in Gwenview (but I also need to review some things in Spectacle first). At least you won't get bored in the meantime with CMYK and the statusbar…
At least you won't get bored in the meantime with CMYK and the statusbar…
I don't think there's ever any danger of boredom :)
I'm also tackling https://bugs.kde.org/show_bug.cgi?id=207802
Cool! Feel free to open a task if you want to discuss a UI design you came up with before implementing something, and look at how other apps are solving this (e.g. Krita, but surely you'll find more, so we can "borrow" the best design for Gwenview…)
Ah, sorry. Thought you meant to enter a percentage for the zoom value. Just ignore my comment. Too many reviews today…