Differential D11736

Pass qtdir variable to cmake cmdline args
ClosedPublic
Actions

Authored by romariorios on Mar 27 2018, 5:31 AM.

Details

Reviewers
mpyne
Commits
R365:51f20932df47: Add qtdir to the cmake commandline
Summary

Pass the qtdir variable from .kdesrc-buildrc directly to the cmake cmdline args -- if present.

Before this change, the qtdir variable seemed to be ignored by the kdesrc-build script.

I hope I'm not missing anything.

BUG: 392387

Diff Detail

Repository
R365 kdesrc-build
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romariorios requested review of this revision.Mar 27 2018, 5:31 AM
romariorios created this revision.
mpyne accepted this revision.Mar 28 2018, 12:59 AM

I believe the official way to integrate a separate Qt is to ensure that the QTDIR's /bin directory is in the PATH.

But, I don't have any problems with this change, as it seems it should allow kdesrc-build to build with a separate Qt even if PATH isn't already setup.

This revision is now accepted and ready to land.Mar 28 2018, 12:59 AM
romariorios edited the summary of this revision. (Show Details)Mar 28 2018, 2:00 AM
Closed by commit R365:51f20932df47: Add qtdir to the cmake commandline (authored by romariorios). · Explain WhyMar 28 2018, 2:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmodules/ksb/BuildSystem/KDE4.pm (6 lines)

Diff 30774

View Options

modules/ksb/BuildSystem/KDE4.pm

Loading...