Differential D11680

Add share action button to received file notification
ClosedPublic
Actions

Authored by mtijink on Mar 25 2018, 12:44 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:94ef1294c572: Add share action button to received file notification
Summary

You can share the just-received file. It doesn't work with a custom download directory (just like opening such files doesn't work yet). It also won't close the notification once shared.

Test Plan

Sharing to other apps works.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink requested review of this revision.Mar 25 2018, 12:44 PM
mtijink created this revision.
nicolasfella added a subscriber: nicolasfella.Mar 25 2018, 2:07 PM
nicolasfella added inline comments.
src/org/kde/kdeconnect/Plugins/SharePlugin/ShareNotification.java
131

Duplicate with line 119?

mtijink updated this revision to Diff 30749.Mar 27 2018, 7:24 PM

Move code in both if/else branch outside if

Restricted Application added a project: KDE Connect. · View Herald TranscriptMar 27 2018, 7:24 PM
nicolasfella accepted this revision.Mar 27 2018, 7:38 PM
This revision is now accepted and ready to land.Mar 27 2018, 7:38 PM
Closed by commit R225:94ef1294c572: Add share action button to received file notification (authored by mtijink). · Explain WhyMar 28 2018, 8:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30812

View Options

res/drawable/ic_share_white.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/ShareNotification.java

Loading...