This enables typing an existing subfolder's name in the location bar and pressing Return/Enter. Previuosly when this was attempted, Ark would extract to baseUrl(). This behavior deviated from a QFileDialog (which we use for Open Dialog), which simply enters the existing subfolder.
Details
Details
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
The bugfix works for me!
| kerfuffle/extractiondialog.cpp | ||
|---|---|---|
| 103 | "ExtractioDialog::slotAccepted() called" would be more useful. | |
| 106 | You can save one indentation level here. if (fileWidget->dirOperator()->selectedItems().isEmpty()) {
// code for setUrl()
...
return;
}
// code for normal extraction.
... | |
| 110 | Double ampersand. | |
| 112 | Maybe QUrl::fromLocalFile() here? | |
Comment Actions
I tested the patch again and the dialog works as expected.
| kerfuffle/extractiondialog.cpp | ||
|---|---|---|
| 105 | Opening brace on the line above | |