Differential D1164

Improve confirm-delete dialog
ClosedPublic
Actions

Authored by elvisangelaccio on Mar 17 2016, 6:10 PM.

Details

Reviewers
rthomsen
Commits
R36:bf125edfe21f: Improve i18n in confirm-delete dialog
Summary

The current dialog can be confusing (at least with the default english i18n). The user has to choose between Delete and Cancel, and it's not so clear which button does what.

This patch replaces the Cancel button with a No button, to resolve this ambiguity.
Other minor fixes: Title Capitalization and handling of singular/plural.

Old dialog:

New dialog:

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 2824.Mar 17 2016, 6:10 PM
elvisangelaccio retitled this revision from to Improve confirm-delete dialog.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
elvisangelaccio updated this object.
elvisangelaccio updated this object.
elvisangelaccio added a subscriber: kde-utils-devel.
rthomsen accepted this revision.Mar 18 2016, 11:01 PM
rthomsen edited edge metadata.

Looks good :)

This revision is now accepted and ready to land.Mar 18 2016, 11:01 PM
Closed by commit R36:bf125edfe21f: Improve i18n in confirm-delete dialog (authored by elvisangelaccio). · Explain WhyMar 19 2016, 11:14 AM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:bf125edfe21f: Improve i18n in confirm-delete dialog.

Revision Contents
Changeset List

PathPackages
Mpart/part.cpp (12 lines)

Diff 2845

View Options

part/part.cpp

Loading...