Differential D11640

Use CMake's FeatureSummary
ClosedPublic
Actions

Authored by wojnilowicz on Mar 24 2018, 10:42 AM.

Details

Reviewers
tbaumgart
Group Reviewers
KMyMoney
Commits
R261:a6ce0a520940: Use CMake's FeatureSummary
Summary

Purpose of this patch is to replace handcrafted KMyMoney build configuration summary with the standard CMake's FeatureSummary macro. The advantage is simplified and standard looking main CMakeLists.txt file e.g. finding and reporting libical has been reduced from 15 to 3 lines.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz requested review of this revision.Mar 24 2018, 10:42 AM
wojnilowicz created this revision.
tbaumgart requested changes to this revision.Mar 24 2018, 1:32 PM

I needed to add the following patch to get the kbanking plugin compiled and installed even though it was detected as enabled:

diff --git a/kmymoney/plugins/CMakeLists.txt b/kmymoney/plugins/CMakeLists.txt
index db07e5d8..7707a276 100644
--- a/kmymoney/plugins/CMakeLists.txt
+++ b/kmymoney/plugins/CMakeLists.txt
@@ -17,9 +17,9 @@ if(ENABLE_SQLSTORAGE)
   add_subdirectory(sql)
 endif()
 
-if (KBANKING_FOUND)
+if (ENABLE_KBANKING)
   add_subdirectory( kbanking )
-endif (KBANKING_FOUND)
+endif()
 
 option(ENABLE_SQLCIPHER "Enable SQLCipher plugin" OFF)
 if (ENABLE_SQLCIPHER)

Otherwise it worked for me

This revision now requires changes to proceed.Mar 24 2018, 1:32 PM
wojnilowicz updated this revision to Diff 30397.Mar 24 2018, 2:36 PM

Enabled KBanking compilation.

tbaumgart accepted this revision.Mar 24 2018, 2:50 PM
This revision is now accepted and ready to land.Mar 24 2018, 2:50 PM
Closed by commit R261:a6ce0a520940: Use CMake's FeatureSummary (authored by wojnilowicz). · Explain WhyMar 24 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30398

View Options

CMakeLists.txt

Loading...
View Options

kmymoney/plugins/CMakeLists.txt

Loading...
View Options

kmymoney/plugins/icalendar/CMakeLists.txt

Loading...