Differential D11632

Completing Multiple Mount Point Support
ClosedPublic
Actions

Authored by abhijeet2096 on Mar 24 2018, 6:41 AM.

Details

Reviewers
stikonas
Commits
R17:e54510b8818e: Multiple mount point support in EditMountPointDialog
Summary

After this patch kpm will support multiple mount points .
Multiple mounts can also be modified and removed.

Diff Detail

Repository
R17 Partition Manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
abhijeet2096 requested review of this revision.Mar 24 2018, 6:41 AM
abhijeet2096 created this revision.
stikonas requested changes to this revision.Mar 25 2018, 11:41 PM

Options are not updated when you choose a new mount point,

E.g. if you have the following lines in /etc/fstab

/dev/sda1 /boot/efi vfat noatime 0 0
/dev/sda1 /boot/efi2 vfat defaults 0 2

and pick /boot/efi2, then noatime option is still selected.

This revision now requires changes to proceed.Mar 25 2018, 11:41 PM
abhijeet2096 updated this revision to Diff 30642.Mar 26 2018, 5:32 PM
abhijeet2096 edited the summary of this revision. (Show Details)

On Go Update of options during edit mount point

stikonas accepted this revision.Mar 30 2018, 6:08 PM

I think it looks good now. Thanks

This revision is now accepted and ready to land.Mar 30 2018, 6:08 PM
Closed by commit R17:e54510b8818e: Multiple mount point support in EditMountPointDialog (authored by abhijeet2096, committed by stikonas). · Explain WhyMar 31 2018, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30642

View Options

src/gui/editmountpointdialog.cpp

Loading...
View Options

src/gui/editmountpointdialogwidget.h

Loading...
View Options

src/gui/editmountpointdialogwidget.cpp

Loading...
View Options

src/gui/editmountpointdialogwidgetbase.ui

Loading...