Unify padding on all sides of app icons in delegates
ClosedPublic

Authored by ngraham on Mar 23 2018, 8:54 PM.

Details

Summary

Without this patch, delegate app icons got more padding on the top and bottom than they did on the sides, which looked a little odd and was was especially noticeable with icons that are square or fit into a square.

This patch makes sides of the icon's invisible frame get the same padding, improving the presentation (even for non-square-ish icons, IMHO).

Test Plan

Normal view:

Compact view:

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Mar 23 2018, 8:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 23 2018, 8:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 23 2018, 8:54 PM
ngraham edited the test plan for this revision. (Show Details)Mar 23 2018, 9:00 PM
ngraham updated this revision to Diff 30354.Mar 23 2018, 9:01 PM

Improve spacing in compact view with this new style

ngraham edited the test plan for this revision. (Show Details)Mar 23 2018, 9:05 PM
ngraham edited the summary of this revision. (Show Details)Mar 23 2018, 9:08 PM
apol accepted this revision.Mar 23 2018, 9:17 PM
This revision is now accepted and ready to land.Mar 23 2018, 9:17 PM
ngraham updated this revision to Diff 30356.Mar 23 2018, 9:23 PM

Very very slightly increase padding (2 -> 3) in compact mode for better aesthetics

ngraham closed this revision.Mar 23 2018, 9:23 PM