Differential D1162

Panel cleanup
ClosedPublic
Actions

Authored by davidedmundson on Mar 17 2016, 2:12 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:1f01ec6e4e86: Panel cleanup
Summary

Counterpart for https://phabricator.kde.org/differential/revision/edit/1161

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 2820.Mar 17 2016, 2:12 PM
davidedmundson retitled this revision from to Panel cleanup.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptMar 17 2016, 2:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson updated this object.Mar 17 2016, 2:13 PM
davidedmundson added a reviewer: Plasma.
mart accepted this revision.Mar 17 2016, 2:45 PM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
desktoppackage/contents/views/Panel.qml
120

what happens if the sequece of events happens:

  1. preferredWidth changes, tries to update the length, but it can't because minimum/maximum don't allow
  2. minimum/maximum change, but preferredWidth doesn't
  3. does the panel size get updated correctly?

(this i guess answers my question on review D1161)

This revision is now accepted and ready to land.Mar 17 2016, 2:45 PM
davidedmundson added inline comments.Mar 17 2016, 3:10 PM
desktoppackage/contents/views/Panel.qml
120

preferredWidth changes, tries to update the length, but it can't because minimum/maximum don't allow

the length will update, the size of the window won't.

everything in the UI should be based around it's actual width not it's preferredWidth.

minimum/maximum change, but preferredWidth doesn't

It will resize to qBound(min, preferred, max);
so it might change, it might not.

does the panel size get updated correctly?

I /think/ so, would be great if you could check too.
I can push to a branch if you want to test (or I think you can get them with arc somehow)

Closed by commit R119:1f01ec6e4e86: Panel cleanup (authored by davidedmundson). · Explain WhyMar 17 2016, 4:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2823

View Options

desktoppackage/contents/views/Panel.qml

Loading...