Add support for hide action
AbandonedPublic

Authored by aheinecke on Mar 23 2018, 7:13 AM.

Details

Reviewers
None
Group Reviewers
Okular
Maniphest Tasks
T8274: Support for PDF form visibility changes
Summary

The hide action can be used to show / hide fields.

Test Plan

Unit test using this action in okular

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
aheinecke requested review of this revision.Mar 23 2018, 7:13 AM
aheinecke created this revision.
aheinecke added inline comments.Mar 23 2018, 7:27 AM
poppler/Link.h
468

I've looked at the spec but did not understand what should be happening with "An indirect reference to an annotation dictionary" and as a result I did not understand what "An array of such dictionaries" would look like. My guess is that it would be similar to the Annotation Ref in a Movie.

But as I could not come up with a test for this using Adobe DC and did not have at an example I did not add API for this and only added API for what I fully understood and could test.

My reasoning is that it is better not to have API, so that it can later be added, instead of wrong API that has to be carried around for compatibility.

aacid added a subscriber: aacid.Mar 26 2018, 7:48 PM

You should really really put this in poppler's bugzilla.

aheinecke abandoned this revision.Apr 9 2018, 1:12 PM

Please see the freedesktop issue for the last version of this patch. It was updated there.