The implementation of xAxisStartAtZero did correspond to api doc,
and imo did not do anything interresting.
This patch makes it possible to force the axes to always start at zero.
Details
Details
- Reviewers
tbaumgart
See tests/AxisStartAtZero
Diff Detail
Diff Detail
- Repository
- R478 KDiagram: Libraries for diagrams
- Branch
- axisstartatzero_danders
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
I am missing the version change for this patch. Increasing the micro version should be enough since only a new method is added. I am not sure though if that is still ABI compatible.
| src/KChart/Cartesian/KChartCartesianCoordinatePlane.cpp | ||
|---|---|---|
| 59 | Does it make sense to change the default? Existing software is certainly affected by this change. I would keep compatibility here and set it to true. | |
| 60 | Same applies here even though the setting did not exist before. Keep it backward compatible which seems to be the case for false. | |
| 413 | I would not check here. It does not hurt to do the assignment in any case even with the same value but safes the comparison operation in all cases. | |
Comment Actions
Thanks for your comments.
I have had some second thoughts about this and will probably find a different way to do it or at least not reuse xAxisStartAtZero (although I think it is very broken).
Anyhow it will not get in until 2.7
| src/KChart/Cartesian/KChartCartesianCoordinatePlane.cpp | ||
|---|---|---|
| 59 | Before false actually meant: "never start at zero", so the default is actually not changed :) | |
| 413 | I included it because it is the way it is done in all setters, but as you say it is probably not necessary. | |
Comment Actions
- Merge branch 'master' into axisstartatzero_danders
- KChart: Make it possible to disable auto adjustment of axis range to data values
Comment Actions
Hmm, I haven't quite figured out what arc does, so here comes a short description:
- Leaves the xAxisStartAtZero stuff as is in current release.
- Depricates xAxisStartAtZero stuff as it does not work as advertized and is buggy. Will be removed in 3.0.
- Add new functions to enable/disable auto adjustment of axes.
- Add the new functionality to tests/AxisControl.