Differential D11518

Use model reset rather than beginRemoveRows() to clear font groups
ClosedPublic
Actions

Authored by dvratil on Mar 20 2018, 5:37 PM.

Details

Reviewers
apol
Commits
R119:d97d360ba408: Use model reset rather than beginRemoveRows() to clear font groups
Summary

Calling beginRemoveRows() when the model is empty hits an assert in
QAbstractItemModel which requires that the "last" argument is less
than model row count, which is not true when the model is empty.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dvratil created this revision.Mar 20 2018, 5:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 20 2018, 5:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dvratil requested review of this revision.Mar 20 2018, 5:37 PM
apol accepted this revision.Mar 20 2018, 6:07 PM
This revision is now accepted and ready to land.Mar 20 2018, 6:07 PM
Closed by commit R119:d97d360ba408: Use model reset rather than beginRemoveRows() to clear font groups (authored by dvratil). · Explain WhyMar 20 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30027

View Options

kcms/kfontinst/kcmfontinst/GroupList.cpp

Loading...