use the new install macro to install bundled packages in the form of an rcc
Details
- Reviewers
kossebau - Group Reviewers
Plasma - Commits
- R114:c505a726b3f1: use plasma_install_bundled_package
added and tried every single plasmoid
Diff Detail
- Repository
- R114 Plasma Addons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
How new is the plasma_install_bundled_package macro? Needs a bump of min kf5 version as well, so people know which plasma-framework version they need at least?
Otherwise patch fine with me, not aware of details, so assume you have your reason for going rcc :)
Any chance of a build flag to install as files like before? I liked it that one could debug things in installed qml files, without having to do an extra build & install step every time.
good point, the macro was added today
Otherwise patch fine with me, not aware of details, so assume you have your reason for going rcc :)
it's mostly loading time for systems with slow storage, spining metal, live systems from usb, arm things and such (may save something also of fast sdds but less noticeable)
Any chance of a build flag to install as files like before? I liked it that one could debug things in installed qml files, without having to do an extra build & install step every time.
technically could be added in that macro, yeah..
Cannot test at the moment, but looks straight forward, so no objection from me.
Besides the unrelated changes, they want to have their own commits :)
applets/fifteenPuzzle/package/contents/ui/main.qml | ||
---|---|---|
24 ↗ | (On Diff #30297) | Unrelated? |
applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp | ||
32 ↗ | (On Diff #30297) | Unrelated? |
applets/fifteenPuzzle/package/contents/ui/main.qml | ||
---|---|---|
24 ↗ | (On Diff #30297) | ah, to me it appeared to break fifteenpuzzle, can you test if also for you using the qrc way, but keeping this unaltered, breaks it? |
applets/fifteenPuzzle/package/contents/ui/main.qml | ||
---|---|---|
24 ↗ | (On Diff #30297) | Sadly cannot test currently, self-compiled plasma-frameworks in custom prefix started to fail/conflict somewhere with system one recently. Given the Private is not used, so this seems just done to move qml class/symbols out of global namespace, could possibly the whole "import" be removed? Or would it still be needed for some secret init triggered by that? |
applets/fifteenPuzzle/plugin/fifteenpuzzleplugin.cpp | ||
32 ↗ | (On Diff #30297) | What is the purpose of this line in general? I do not understand the purpose, both with old qmlName and new qmlName argument. It was also not discussed in https://git.reviewboard.kde.org/r/120949/ so picture me with big ? in my eyes :) |