Plan: fix build with Qt 5.6
ClosedPublic
Actions

Authored by wbauer on Mar 20 2018, 9:28 AM.

Details

Reviewers

Commits

R8:aeb65f8f32a9: Plan: fix build with Qt 5.6
R1026:2840bff2f19d: Plan: fix build with Qt 5.6

Summary

The QAction constructor takes two arguments, text and parent.
The parent argument is optional since Qt 5.7 only, it needs to be specified with earlier versions.

Also, text should actually be a QString, so use QStringLiteral to "convert" it.

Test Plan

Compiles with Qt 5.6 now, before I got this error:

/home/abuild/rpmbuild/BUILD/calligraplan-3.1.0/src/libs/ui/kpttaskeditor.cpp: In member function 'void KPlato::TaskEditor::editTasks(const QList<KPlato::Task*>&, const QPoint&)':
/home/abuild/rpmbuild/BUILD/calligraplan-3.1.0/src/libs/ui/kpttaskeditor.cpp:625:32: error: no matching function for call to 'QAction::QAction(const char [8])'
     QAction tasksEdit("Edit...");
                                ^

Still compiles with Qt 5.9.4 and 5.10.0 too.