Differential D1150

Create cursors with correct DevicePixelRatio
ClosedPublic
Actions

Authored by abrahams on Mar 16 2016, 12:02 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Maniphest Tasks
T1822: Cursor is out of alignment for high DPI screens on Windows
Summary

This helps on Windows, want to verify it doesn't break anything on Linux.

Diff Detail

Repository
R37 Krita
Branch
cursorDPR (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
abrahams updated this revision to Diff 2790.Mar 16 2016, 12:02 AM
abrahams retitled this revision from to Create cursors with correct DevicePixelRatio.
abrahams updated this object.
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: Krita.
abrahams updated this revision to Diff 2791.Mar 16 2016, 12:05 AM

Remove some accidentally commited comment lines

abrahams updated this revision to Diff 2792.Mar 16 2016, 12:14 AM

Add Qt bug report in commit message

rempt added a subscriber: rempt.Mar 16 2016, 7:11 AM

Hm, what I don't get is removing the hotspot calculation if no hotspot is set -- why isn't that needed anymore?

abrahams added a comment.Mar 16 2016, 1:46 PM

The only case that is removed is when hotspotX is set to -1, which is supposed to indicate the center is bitmap.width / 2. But Qt does that already if you pass hotspotX = -1 through straight into the QCursor constructor, so there wasn't really a point to doing that as far as I could tell.

rempt accepted this revision.Mar 16 2016, 3:40 PM
rempt added a reviewer: rempt.

Awesome, okay!

This revision is now accepted and ready to land.Mar 16 2016, 3:40 PM
abrahams closed this revision.Mar 16 2016, 3:50 PM

Landed this together with D1151.

Revision Contents
Changeset List

PathPackages
Mlibs/ui/kis_cursor.cc (16 lines)

Diff 2792

View Options

libs/ui/kis_cursor.cc

Loading...