Differential D11499

Fix warnings
AbandonedPublic
Actions

Authored by apol on Mar 19 2018, 6:47 PM.

Details

Reviewers
mart
Summary

Apparently sometimes controlRoot.ListView.view is null

Test Plan

Ran Discover, it worked

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 19 2018, 6:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2018, 6:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Mar 19 2018, 6:47 PM
mart accepted this revision.Mar 19 2018, 6:50 PM
mart added a subscriber: mart.

should go deeper in this issue.. i already encountered it, tough it seems that ListView.view is always null until the component completes, which could potentially make it a Qt bug

This revision is now accepted and ready to land.Mar 19 2018, 6:50 PM
apol abandoned this revision.Mar 27 2018, 11:13 PM

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/MenuItem.qml (4 lines)

Diff 29941

View Options

org.kde.desktop/MenuItem.qml

Loading...