Differential D11412

Fix search result rectangle position
ClosedPublic
Actions

Authored by mglb on Mar 17 2018, 3:14 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:6b8cf60adf51: Fix search result rectangle position
Summary

Include top margin in the rectangle's vertical position, so it will
be drawn in correct position when TerminalCenter is set and/or
TerminalMargin is larget than 0.

Preview:

Test Plan
  • Run konsole -p TerminalMargin=8
  • Display something
  • Run search and search for something
  • The blue rectangle should cover current result line

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mglb created this revision.Mar 17 2018, 3:14 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 17 2018, 3:14 PM
Restricted Application added a subscriber: Konsole. · View Herald Transcript
mglb requested review of this revision.Mar 17 2018, 3:14 PM
mglb edited the summary of this revision. (Show Details)Mar 17 2018, 3:18 PM
mglb edited the test plan for this revision. (Show Details)
mglb added a reviewer: Konsole.
hindenburg accepted this revision.Mar 17 2018, 4:35 PM
hindenburg added a subscriber: hindenburg.

thanks

This revision is now accepted and ready to land.Mar 17 2018, 4:35 PM
Closed by commit R319:6b8cf60adf51: Fix search result rectangle position (authored by mglb, committed by hindenburg). · Explain WhyMar 17 2018, 5:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.cpp (2 lines)

Diff 29759

View Options

src/TerminalDisplay.cpp

Loading...