Differential D11336

Keep click position in focus on middle-click zoom
ClosedPublic
Actions

Authored by muhlenpfordt on Mar 14 2018, 6:27 PM.

Details

Reviewers

rkflx

Group Reviewers

Gwenview

Commits

R260:1e66de8f8f26: Keep click position in focus on middle-click zoom

Summary

Clicking on an image in View Mode with the middle mouse button toggles
between Fit and 100% zoom modes. The image zoomed to 100% is
always scrolled to the image center.
This patch keeps the clicked location in focus as it is done while
zooming with Ctrl+Scroll.

FEATURE: 308335

Test Plan

Open a big image in View Mode
Middle-click on different locations over the image
The 100% zoom view should keep the clicked location in focus

Diff Detail

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

muhlenpfordt requested review of this revision.Mar 14 2018, 6:27 PM

muhlenpfordt created this revision.

The click position is not centered but kept at the same location as it is done with Ctrl+Scroll / Ctrl+Click. This feels more convenient to me than the click location jumping to viewport center as suggested in the bug report.
But maybe there are other opinions to this?

muhlenpfordt mentioned this in T8220: Zoom buttons out of sync sometimes.Mar 14 2018, 6:30 PM

I strongly agree this is much better. Patch behaves well for me.

@huoni Thanks for testing, I like it too ;)

The patch is so simple and the behaviour so straightforward, yet it took 6 years to fix the bug…

This revision is now accepted and ready to land.Mar 15 2018, 11:34 AM

Closed by commit R260:1e66de8f8f26: Keep click position in focus on middle-click zoom (authored by muhlenpfordt). · Explain WhyMar 15 2018, 1:47 PM

This revision was automatically updated to reflect the committed changes.

rkflx mentioned this in D14093: Toggle between zoom options "Fit"/"Fill" and "100%" on multiple activation.Jul 16 2018, 10:47 AM

Revision Contents
Changeset List

			Path	Packages
M			lib/documentview/abstractimageview.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29519	8bd2f62		Mar 14 2018, 6:27 PM	★	★
Diff 2	29597	d850c3f	R260:1e66de8f8f2664451279b23f2e6e7cef3ba372bc	Mar 15 2018, 1:45 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
551632d038b3	82371c1f10dd	8bd2f625c679	Peter Mühlenpfordt	Keep click position in focus on middle-click zoom (Show More…)	Mar 14 2018, 2:26 PM

Diff 29597

View Options

lib/documentview/abstractimageview.cpp