Differential D11328

Added check for duplicate bookmarks
AbandonedPublic
Actions

Authored by cullmann on Mar 14 2018, 1:00 PM.

Details

Reviewers
drosca
anmolgautam
Group Reviewers
Falkon
Summary

context menu on webpage and tabs creates duplicate bookmarks if done more than once because there is no check if the bookmark already exists.

Diff Detail

Repository
R875 Falkon
Lint
Lint Skipped
Unit
Unit Tests Skipped
anmolgautam requested review of this revision.Mar 14 2018, 1:00 PM
anmolgautam created this revision.
drosca requested changes to this revision.Mar 30 2018, 10:45 AM
drosca added inline comments.
src/lib/bookmarks/bookmarkstools.cpp
151

As discussed on IRC, please only leave this part in the patch.

152

warningLabel or just label

This revision now requires changes to proceed.Mar 30 2018, 10:45 AM
Restricted Application added a subscriber: falkon. · View Herald TranscriptMar 30 2018, 10:45 AM
cullmann added a subscriber: cullmann.Mar 4 2019, 6:57 PM

Hi, any updates on this?
Thanks!

cullmann commandeered this revision.Jul 3 2019, 6:43 PM
cullmann added a reviewer: anmolgautam.

Please reopen after you have revised the patch, thanks!

cullmann abandoned this revision.Jul 3 2019, 6:43 PM

Revision Contents
Changeset List

PathPackages
Msrc/lib/bookmarks/bookmarkstools.cpp (39 lines)

Diff 29496

View Options

src/lib/bookmarks/bookmarkstools.cpp

Loading...