Differential D11313

Refactor GCSlider
ClosedPublic
Actions

Authored by abreton on Mar 14 2018, 7:37 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8182: Refactor GCSlider to avoid duplication
Summary

https://phabricator.kde.org/T8182

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
abreton created this revision.Mar 14 2018, 7:37 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 14 2018, 7:37 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
jjazeix added inline comments.Mar 14 2018, 8:47 AM
src/core/GCSlider.qml
21 ↗(On Diff #29461)

Please use the same version as or the other qml files

56 ↗(On Diff #29461)

remove width, always anchor to parent and use enabled property

abreton updated this revision to Diff 29477.Mar 14 2018, 9:42 AM

Change QtQuick to 2.6 and uses the "enabled" property in MouseArea instead of "width"

jjazeix accepted this revision.Mar 14 2018, 9:56 AM

This seems good to me (not yet tested). Maybe you can check if this can be used in photo_hunter activity (as it also uses sliders), but as the Style is different for it, it may not be useful.

This revision is now accepted and ready to land.Mar 14 2018, 9:56 AM

Revision Contents
Changeset List

Diff 29477

View Options

src/activities/menu/ConfigurationItem.qml

Loading...
View Options

src/core/GCSlider.qml

Loading...