Differential D11267

documented core items
ClosedPublic
Actions

Authored by asagtani on Mar 12 2018, 4:51 PM.

Tags

Subscribers

jjazeix, asagtani, KDE Edu

Details

Reviewers

Group Reviewers

Maniphest Tasks

T7586: Document "Numpad.qml"
T7590: Document "AnswerButton.qml"
T7587: Document "DominoNumber.qml"
T7588: Document "Domino.qml"

Summary

modified:   src/core/AnswerButton.qml

modified: src/core/Domino.qml
modified: src/core/DominoNumber.qml
modified: src/core/NumPad.qml

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

asagtani created this revision.Mar 12 2018, 4:51 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 12 2018, 4:51 PM

Restricted Application added a subscriber: KDE Edu. · View Herald Transcript

asagtani requested review of this revision.Mar 12 2018, 4:51 PM

asagtani added tasks: T7588: Document "Domino.qml", T7587: Document "DominoNumber.qml", T7590: Document "AnswerButton.qml", T7586: Document "Numpad.qml".

jjazeix added a subscriber: jjazeix.Mar 12 2018, 8:42 PM

jjazeix added inline comments.

src/core/AnswerButton.qml
28 ↗	(On Diff #29339)	option
src/core/DominoNumber.qml
25 ↗	(On Diff #29339)	integers (0 - 9)
26 ↗	(On Diff #29339)	numbers
41 ↗	(On Diff #29339)	number
src/core/NumPad.qml
30 ↗	(On Diff #29339)	It also contains the backspace button to remove the last input value. It is also only displayed when the "virtual keyboard" is enabled in the options.

jjazeix requested changes to this revision.Mar 12 2018, 8:43 PM

This revision now requires changes to proceed.Mar 12 2018, 8:43 PM

made the required changes

can you just fix no. to number and then it's good, you can commit.

Thank you!

src/core/DominoNumber.qml
26 ↗	(On Diff #29339)	numbers

This revision is now accepted and ready to land.Mar 23 2018, 7:36 AM

Made the changes and Committed --> https://phabricator.kde.org/R2:0f4f737a5e2795f74318993458ddeacc9f89ea38

Revision Contents
Changeset List

			Path	Packages
M			src/core/AnswerButton.qml (78 lines)
M			src/core/Domino.qml (26 lines)
M			src/core/DominoNumber.qml (52 lines)
M			src/core/NumPad.qml (69 lines)

Diff 29355

src/core/AnswerButton.qml

Loading...

src/core/Domino.qml

Loading...

src/core/DominoNumber.qml

Loading...

src/core/NumPad.qml

Loading...