Improve password-protection status in the properties dialog
ClosedPublic
Actions

Authored by elvisangelaccio on Mar 11 2016, 6:57 PM.

Details

Reviewers

Commits

R36:2dd4b816abd8: Improve password-protection status in the properties dialog

Summary

Currently there is a bug in the props dialog (well, in the Archive class actually).
If you create an encrypted archive with CreateDialog, the props dialog claims that is unencrypted.
While looking for a fix, I thought that would be nice to also tell the user whether the
archive is header-encrypted.

To do so, a new EncryptionType enum was introduced as archive property.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio updated this revision to Diff 2720.Mar 11 2016, 6:57 PM

elvisangelaccio retitled this revision from to Improve password-protection status in the properties dialog.

elvisangelaccio added a reviewer: rthomsen.

elvisangelaccio updated this object.

Restricted Application added a project: Ark. · View Herald TranscriptMar 11 2016, 6:57 PM

Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Screen of the new property about header-encryption

Code looks good. I tested opening/creating password-protected rar with/without headerenc.

This revision is now accepted and ready to land.Mar 12 2016, 10:30 AM

Closed by commit R36:2dd4b816abd8: Improve password-protection status in the properties dialog (authored by elvisangelaccio). · Explain WhyMar 12 2016, 11:00 AM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:2dd4b816abd8: Improve password-protection status in the properties dialog.

Revision Contents
Changeset List

			Path	Packages
M			autotests/kerfuffle/archivetest.cpp (26 lines)
M			autotests/plugins/cliunarchiverplugin/cliunarchivertest.cpp (12 lines)
M			kerfuffle/addtoarchive.cpp (3 lines)
M			kerfuffle/archive_kerfuffle.h (23 lines)
M			kerfuffle/archive_kerfuffle.cpp (40 lines)
M			kerfuffle/archiveinterface.h (7 lines)
M			kerfuffle/propertiesdialog.cpp (13 lines)
M			part/archivemodel.h (7 lines)
M			part/archivemodel.cpp (13 lines)
M			part/part.cpp (7 lines)