Differential D11246

Reset rendition attributes to default when switching to alternate screen
ClosedPublic
Actions

Authored by ahmadsamir on Mar 11 2018, 7:44 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:7934bcff279b: Reset rendition attributes to default when switching to alternate screen
Summary

Call setDefaultRendition() before switching to the alternate screen

Quitting vim after using a color scheme which sets the character
background color doesn't clear that attribute in the alternate screen.
This affects other programs which use the alternate screen when run
right after quitting vim, e.g. less.

This issue appears to only happen with certain graphics cards/drivers.

BUG: 328287
FIXED-IN: 18.04

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Mar 11 2018, 7:44 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 11 2018, 7:44 PM
ahmadsamir requested review of this revision.Mar 11 2018, 7:44 PM
ahmadsamir added a comment.Mar 11 2018, 7:45 PM

FWIW, a similar bug existed in gnome-terminal: https://bugzilla.gnome.org/show_bug.cgi?id=709930

hindenburg added a comment.Mar 11 2018, 11:49 PM

Can you reproduce the bug? I can't on any of my systems nor any VMs.

ahmadsamir added a comment.Mar 12 2018, 4:41 AM

Yes, I can still reproduce it with bash, zsh and tcsh. FWIW, I have a system with an nvidia gfx, using the proprietary driver.

hindenburg accepted this revision.Mar 12 2018, 11:10 AM

Ok that's fine - thanks

This revision is now accepted and ready to land.Mar 12 2018, 11:10 AM
hindenburg retitled this revision from Call setDefaultRendition() before switching to the alternate screen to Reset rendition attributes to default before switching to the alternate screen.Mar 12 2018, 12:08 PM
hindenburg edited the summary of this revision. (Show Details)
hindenburg retitled this revision from Reset rendition attributes to default before switching to the alternate screen to Reset rendition attributes to default when switching to alternate screen.Mar 12 2018, 12:10 PM

phabricator really needs a way to tell column #s so they match the commit guidelines.

Closed by commit R319:7934bcff279b: Reset rendition attributes to default when switching to alternate screen (authored by ahmadsamir, committed by hindenburg). · Explain WhyMar 12 2018, 12:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/Vt102Emulation.cpp (1 line)

Diff 29327

View Options

src/Vt102Emulation.cpp

Loading...