Differential D1122

Disabled toggling of act. switcher immediately after it has been toggled
ClosedPublic
Actions

Authored by ivan on Mar 11 2016, 4:08 PM.

Details

Reviewers
mart
Commits
R119:174aa2171804: Disabled toggling of act. switcher immediately after it has been toggled
Summary

There is a current issue when the user presses meta+q while the
switcher is shown. It gets hidden (the switcher lost the focus) and
shown again (because the toggle method does not know it has been hidden
a moment ago.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ivan updated this revision to Diff 2711.Mar 11 2016, 4:08 PM
ivan retitled this revision from to Disabled toggling of act. switcher immediately after it has been toggled.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
ivan added a reviewer: mart.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 11 2016, 4:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan updated this revision to Diff 2713.Mar 11 2016, 4:27 PM

Added the comment regarding the Qt bug:

Qt has a bug where invoking a global shortcut steal focus from the
current window, which makes the activity switcher hide itself and
popup again when the user presses meta+q (instead of just hiding).
This 'timestamp' forbids the switcher to be toggled consecutively.

The relevant patch to Qt is here:

https://codereview.qt-project.org/#/c/143658/
ivan updated this revision to Diff 2715.Mar 11 2016, 4:29 PM

Updated the commit comment

Closed by commit R119:174aa2171804: Disabled toggling of act. switcher immediately after it has been toggled (authored by ivan). · Explain WhyMar 11 2016, 4:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2715

View Options

desktoppackage/contents/views/Desktop.qml

Loading...