Differential D1119

Improve Archive properties
ClosedPublic
Actions

Authored by elvisangelaccio on Mar 11 2016, 11:31 AM.

Details

Reviewers
rthomsen
Commits
R36:3ff03538e14c: Improve Archive properties
Summary

The Q_PROPERTY docs does not enforce READ methods to be const. So I think we
can leave the listIfNotListed() function, which is a needed optimization with
huge archives.

However, we can use the CONSTANT keywords to mark properties that are not
supposed to change during the archive lifetime.

This patch also adds new properties and fixes a bug in Archive::setPassword()
(with a dedicated unit test).

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 2701.Mar 11 2016, 11:31 AM
elvisangelaccio retitled this revision from to Improve Archive properties.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a project: Ark. · View Herald TranscriptMar 11 2016, 11:31 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio updated this revision to Diff 2702.Mar 11 2016, 11:49 AM
  • I've committed the bugfix + unit test separately (578fc87), since it's unrelated from this patch.
rthomsen accepted this revision.Mar 11 2016, 12:56 PM
rthomsen edited edge metadata.

Looks good :)

This revision is now accepted and ready to land.Mar 11 2016, 12:56 PM
Closed by commit R36:3ff03538e14c: Improve Archive properties (authored by elvisangelaccio). · Explain WhyMar 11 2016, 1:45 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:3ff03538e14c: Improve Archive properties.

Revision Contents
Changeset List

Diff 2706

View Options

kerfuffle/archive_kerfuffle.h

Loading...
View Options

kerfuffle/archive_kerfuffle.cpp

Loading...